require-default-props.js 6.4 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193
  1. /**
  2. * @fileOverview Enforce a defaultProps definition for every prop that is not a required prop.
  3. * @author Vitor Balocco
  4. */
  5. 'use strict';
  6. const entries = require('object.entries');
  7. const values = require('object.values');
  8. const Components = require('../util/Components');
  9. const docsUrl = require('../util/docsUrl');
  10. const astUtil = require('../util/ast');
  11. const report = require('../util/report');
  12. // ------------------------------------------------------------------------------
  13. // Rule Definition
  14. // ------------------------------------------------------------------------------
  15. const messages = {
  16. noDefaultWithRequired: 'propType "{{name}}" is required and should not have a defaultProps declaration.',
  17. shouldHaveDefault: 'propType "{{name}}" is not required, but has no corresponding defaultProps declaration.',
  18. noDefaultPropsWithFunction: 'Don’t use defaultProps with function components.',
  19. shouldAssignObjectDefault: 'propType "{{name}}" is not required, but has no corresponding default argument value.',
  20. destructureInSignature: 'Must destructure props in the function signature to initialize an optional prop.',
  21. };
  22. module.exports = {
  23. meta: {
  24. docs: {
  25. description: 'Enforce a defaultProps definition for every prop that is not a required prop',
  26. category: 'Best Practices',
  27. url: docsUrl('require-default-props'),
  28. },
  29. messages,
  30. schema: [{
  31. type: 'object',
  32. properties: {
  33. forbidDefaultForRequired: {
  34. type: 'boolean',
  35. },
  36. classes: {
  37. enum: ['defaultProps', 'ignore'],
  38. },
  39. functions: {
  40. enum: ['defaultArguments', 'defaultProps', 'ignore'],
  41. },
  42. /**
  43. * @deprecated
  44. */
  45. ignoreFunctionalComponents: {
  46. type: 'boolean',
  47. },
  48. },
  49. additionalProperties: false,
  50. }],
  51. },
  52. create: Components.detect((context, components) => {
  53. const configuration = context.options[0] || {};
  54. const forbidDefaultForRequired = configuration.forbidDefaultForRequired || false;
  55. const classes = configuration.classes || 'defaultProps';
  56. /**
  57. * @todo
  58. * - Remove ignoreFunctionalComponents
  59. * - Change default to 'defaultArguments'
  60. */
  61. const functions = configuration.ignoreFunctionalComponents
  62. ? 'ignore'
  63. : configuration.functions || 'defaultProps';
  64. /**
  65. * Reports all propTypes passed in that don't have a defaultProps counterpart.
  66. * @param {Object[]} propTypes List of propTypes to check.
  67. * @param {Object} defaultProps Object of defaultProps to check. Keys are the props names.
  68. * @return {void}
  69. */
  70. function reportPropTypesWithoutDefault(propTypes, defaultProps) {
  71. entries(propTypes).forEach((propType) => {
  72. const propName = propType[0];
  73. const prop = propType[1];
  74. if (!prop.node) {
  75. return;
  76. }
  77. if (prop.isRequired) {
  78. if (forbidDefaultForRequired && defaultProps[propName]) {
  79. report(context, messages.noDefaultWithRequired, 'noDefaultWithRequired', {
  80. node: prop.node,
  81. data: { name: propName },
  82. });
  83. }
  84. return;
  85. }
  86. if (defaultProps[propName]) {
  87. return;
  88. }
  89. report(context, messages.shouldHaveDefault, 'shouldHaveDefault', {
  90. node: prop.node,
  91. data: { name: propName },
  92. });
  93. });
  94. }
  95. /**
  96. * If functions option is 'defaultArguments', reports defaultProps is used and all params that doesn't initialized.
  97. * @param {Object} componentNode Node of component.
  98. * @param {Object[]} declaredPropTypes List of propTypes to check `isRequired`.
  99. * @param {Object} defaultProps Object of defaultProps to check used.
  100. */
  101. function reportFunctionComponent(componentNode, declaredPropTypes, defaultProps) {
  102. if (defaultProps) {
  103. report(context, messages.noDefaultPropsWithFunction, 'noDefaultPropsWithFunction', {
  104. node: componentNode,
  105. });
  106. }
  107. const props = componentNode.params[0];
  108. const propTypes = declaredPropTypes;
  109. if (!props) {
  110. return;
  111. }
  112. if (props.type === 'Identifier') {
  113. const hasOptionalProp = values(propTypes).some((propType) => !propType.isRequired);
  114. if (hasOptionalProp) {
  115. report(context, messages.destructureInSignature, 'destructureInSignature', {
  116. node: props,
  117. });
  118. }
  119. } else if (props.type === 'ObjectPattern') {
  120. props.properties.filter((prop) => {
  121. if (prop.type === 'RestElement' || prop.type === 'ExperimentalRestProperty') {
  122. return false;
  123. }
  124. const propType = propTypes[prop.key.name];
  125. if (!propType || propType.isRequired) {
  126. return false;
  127. }
  128. return prop.value.type !== 'AssignmentPattern';
  129. }).forEach((prop) => {
  130. report(context, messages.shouldAssignObjectDefault, 'shouldAssignObjectDefault', {
  131. node: prop,
  132. data: { name: prop.key.name },
  133. });
  134. });
  135. }
  136. }
  137. // --------------------------------------------------------------------------
  138. // Public API
  139. // --------------------------------------------------------------------------
  140. return {
  141. 'Program:exit'() {
  142. const list = components.list();
  143. values(list).filter((component) => {
  144. if (functions === 'ignore' && astUtil.isFunctionLike(component.node)) {
  145. return false;
  146. }
  147. if (classes === 'ignore' && astUtil.isClass(component.node)) {
  148. return false;
  149. }
  150. // If this defaultProps is "unresolved", then we should ignore this component and not report
  151. // any errors for it, to avoid false-positives with e.g. external defaultProps declarations or spread operators.
  152. if (component.defaultProps === 'unresolved') {
  153. return false;
  154. }
  155. return component.declaredPropTypes !== undefined;
  156. }).forEach((component) => {
  157. if (functions === 'defaultArguments' && astUtil.isFunctionLike(component.node)) {
  158. reportFunctionComponent(
  159. component.node,
  160. component.declaredPropTypes,
  161. component.defaultProps
  162. );
  163. } else {
  164. reportPropTypesWithoutDefault(
  165. component.declaredPropTypes,
  166. component.defaultProps || {}
  167. );
  168. }
  169. });
  170. },
  171. };
  172. }),
  173. };