123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307 |
- /**
- * @fileoverview max lines per function for react
- * @author Lisonglin
- */
- "use strict";
- //------------------------------------------------------------------------------
- // Requirements
- //------------------------------------------------------------------------------
- const getFunctionNameWithKind = require("eslint-plugin-react-func/lib/utils/getFunctionNameWithKind.js");
- const lodash = require("lodash");
- //------------------------------------------------------------------------------
- // Constants
- //------------------------------------------------------------------------------
- const OPTIONS_SCHEMA = {
- type: "object",
- properties: {
- max: {
- type: "integer",
- minimum: 0
- },
- skipComments: {
- type: "boolean"
- },
- skipBlankLines: {
- type: "boolean"
- },
- IIFEs: {
- type: "boolean"
- }
- },
- additionalProperties: false
- };
- const OPTIONS_OR_INTEGER_SCHEMA = {
- oneOf: [
- OPTIONS_SCHEMA,
- {
- type: "integer",
- minimum: 1
- }
- ]
- };
- /**
- * Given a list of comment nodes, return a map with numeric keys (source code line numbers) and comment token values.
- * @param {Array} comments An array of comment nodes.
- * @returns {Map.<string,Node>} A map with numeric keys (source code line numbers) and comment token values.
- */
- function getCommentLineNumbers(comments) {
- const map = new Map();
- comments.forEach(comment => {
- for (let i = comment.loc.start.line; i <= comment.loc.end.line; i++) {
- map.set(i, comment);
- }
- });
- return map;
- }
- //------------------------------------------------------------------------------
- // Rule Definition
- //------------------------------------------------------------------------------
- module.exports = {
- meta: {
- type: "suggestion",
- docs: {
- description: "enforce a maximum number of line of code in a function",
- category: "Stylistic Issues",
- recommended: false,
- url: "https://eslint.org/docs/rules/max-lines-per-function"
- },
- schema: [
- OPTIONS_OR_INTEGER_SCHEMA
- ],
- messages: {
- exceed: "{{name}} has too many lines ({{lineCount}}). Maximum allowed is {{maxLines}}."
- }
- },
- create(context) {
- const sourceCode = context.getSourceCode();
- const lines = sourceCode.lines;
- const option = context.options[0];
- let maxLines = 50;
- let skipComments = false;
- let skipBlankLines = false;
- let IIFEs = false;
- if (typeof option === "object") {
- maxLines = typeof option.max === "number" ? option.max : 50;
- skipComments = !!option.skipComments;
- skipBlankLines = !!option.skipBlankLines;
- IIFEs = !!option.IIFEs;
- } else if (typeof option === "number") {
- maxLines = option;
- }
- const commentLineNumbers = getCommentLineNumbers(sourceCode.getAllComments());
- //--------------------------------------------------------------------------
- // Helpers
- //--------------------------------------------------------------------------
- /**
- * Tells if a comment encompasses the entire line.
- * @param {string} line The source line with a trailing comment
- * @param {number} lineNumber The one-indexed line number this is on
- * @param {ASTNode} comment The comment to remove
- * @returns {boolean} If the comment covers the entire line
- */
- function isFullLineComment(line, lineNumber, comment) {
- const start = comment.loc.start,
- end = comment.loc.end,
- isFirstTokenOnLine = start.line === lineNumber && !line.slice(0, start.column).trim(),
- isLastTokenOnLine = end.line === lineNumber && !line.slice(end.column).trim();
- return comment &&
- (start.line < lineNumber || isFirstTokenOnLine) &&
- (end.line > lineNumber || isLastTokenOnLine);
- }
- /**
- * Identifies is a node is a FunctionExpression which is part of an IIFE
- * @param {ASTNode} node Node to test
- * @returns {boolean} True if it's an IIFE
- */
- function isIIFE(node) {
- return (node.type === "FunctionExpression" || node.type === "ArrowFunctionExpression") && node.parent && node.parent.type === "CallExpression" && node.parent.callee === node;
- }
- /**
- * Identifies is a node is a FunctionExpression which is embedded within a MethodDefinition or Property
- * @param {ASTNode} node Node to test
- * @returns {boolean} True if it's a FunctionExpression embedded within a MethodDefinition or Property
- */
- function isEmbedded(node) {
- if (!node.parent) {
- return false;
- }
- if (node !== node.parent.value) {
- return false;
- }
- if (node.parent.type === "MethodDefinition") {
- return true;
- }
- if (node.parent.type === "Property") {
- return node.parent.method === true || node.parent.kind === "get" || node.parent.kind === "set";
- }
- return false;
- }
- function isContainJSX(type) {
- return ['JSXElement', 'JSXFragment'].includes(type)
- }
- function checkIsJSXElement(node) {
- const functionText = sourceCode.getText(node) || '';
- return (functionText.includes('<') && (functionText.includes('/>') || functionText.includes('</')));
- }
- function checkIsCustomHook(name) {
- return /use*/.test(name);
- }
- function isReactEle(node) {
- const bodyType = lodash.get(node, 'body.type', '');
- const keyName = lodash.get(node, 'key.name', '');
- const parentName = lodash.get(node, 'parent.id.name', '');
- const functionName = getFunctionNameWithKind(node);
- const isClassComponent = keyName === 'render';
- const isJSXElement = isContainJSX(bodyType) || checkIsJSXElement(node);
- const isCustomHook = checkIsCustomHook(functionName) || checkIsCustomHook(parentName);
- const isReactEle = isJSXElement || isClassComponent || isCustomHook;
- return isReactEle;
- }
- function getCurrentFunctionTextLineArray(node) {
- return sourceCode.lines.slice(node.loc.start.line - 1, node.loc.end.line);
- }
- function checkIsCommonFunction(lineTexts) {
- return lineTexts[0].includes('function');
- }
- function checkIsObjectFunction(lineTexts) {
- try {
- const isCommonFunction = checkIsCommonFunction(lineTexts);
- if (isCommonFunction) return false;
-
- const arrowOperatorIndex = lineTexts.findIndex(line => line.includes('=>'));
- const isNotContainArrowFunction = arrowOperatorIndex === -1;
-
- if (isNotContainArrowFunction) return true;
-
- const rightParenthesesIndex = lineTexts.findIndex(line => line.includes(')'));
-
- if (rightParenthesesIndex === -1) return false;
-
- return (rightParenthesesIndex < arrowOperatorIndex);
- } catch (e) {
- return false;
- }
- }
- function getArgumentsLineNum(node) {
- try {
- if (isReactEle(node)) return 0;
- const emptyLine = 0;
- let argumentsLineNum = emptyLine;
- const lineTexts = getCurrentFunctionTextLineArray(node);
- const isCommonFunction = checkIsCommonFunction(lineTexts);
- const isObjectFunction = checkIsObjectFunction(lineTexts);
- const isArrowFunction = !isCommonFunction && !isObjectFunction;
- if (isCommonFunction || isObjectFunction) {
- argumentsLineNum = lineTexts.findIndex(line => line.includes(')'));
- }
- if (isArrowFunction) {
- argumentsLineNum = lineTexts.findIndex(line => line.includes('=>'));
- }
- if (argumentsLineNum === -1) return emptyLine;
- return argumentsLineNum;
- } catch(e) {
- return emptyLine;
- }
- }
- /**
- * Count the lines in the function
- * @param {ASTNode} funcNode Function AST node
- * @returns {void}
- * @private
- */
- function processFunction(funcNode) {
- const node = isEmbedded(funcNode) ? funcNode.parent : funcNode;
- const argumentsLineNum = getArgumentsLineNum(node);
- if (!IIFEs && isIIFE(node)) {
- return;
- }
- let lineCount = 0;
- for (let i = node.loc.start.line - 1; i < node.loc.end.line; ++i) {
- const line = lines[i];
-
- if (skipComments) {
- if (commentLineNumbers.has(i + 1) && isFullLineComment(line, i + 1, commentLineNumbers.get(i + 1))) {
- continue;
- }
- }
- if (skipBlankLines) {
- if (line.match(/^\s*$/u)) {
- continue;
- }
- }
- lineCount++;
- }
- const baseFunctionLineNum = 2
- lineCount = lineCount - argumentsLineNum - baseFunctionLineNum;
- const isOverLength = lineCount > maxLines;
- const isError = isOverLength && !isReactEle(node);
- if (isError) {
- const functionName = getFunctionNameWithKind(node);
- const name = lodash.upperFirst(functionName);
- context.report({
- node,
- messageId: "exceed",
- data: { name, lineCount, maxLines }
- });
- }
- }
- //--------------------------------------------------------------------------
- // Public API
- //--------------------------------------------------------------------------
- return {
- FunctionDeclaration: processFunction,
- FunctionExpression: processFunction,
- ArrowFunctionExpression: processFunction
- };
- }
- };
|